ICU-23105 Update NumberFormatterApiTest/formatUnitsAliases to fail when the units are not parsable #3670
+46
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en the units are not parsable - Refactor test cases to use unique_ptr for MeasureUnit in C++ and adjust constructor in Java. - Introduce logging for known issues related to unit aliases to ensure compatibility with callers. - Update expected formats for unit aliases in both C++ and Java test files.
younies
force-pushed
the
ensure-unit-aliases
branch
from
a291bdc to
65a9177
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
6 tasks
markusicu
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue occurred because unit parsing failures were not checked or the status reset. As a result, if one unit failed to parse, the status carried an error and caused all subsequent test cases to fail.
Changes made:
unique_ptrforMeasureUnitin C++ and adjusted the constructor in Java.Note: This issue still exists — ICU-23222.
Checklist